chore: handle kafka transport with confluentkafka ✨ #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Jul 14, 2022
| @@ -24,6 +24,7 @@ def supports_librabbitmq() -> bool | None: | |||
| 'pyamqp': 'kombu.transport.pyamqp:Transport', | |||
| 'librabbitmq': 'kombu.transport.librabbitmq:Transport', | |||
| 'confluentkafka': 'kombu.transport.confluentkafka:Transport', | |||
| 'kafka': 'kombu.transport.confluentkafka:Transport', | |||
There was a problem hiding this comment.
we might add another back end in near future, like aiokafka, so i am not in favor of adding this change right now :)
There was a problem hiding this comment.
Well @auvipy , for the moment, you would want to give some API to the already-implemented logic. If in the future, you plan to change the logic, you'd just change one line here. No hard feelings :)
There was a problem hiding this comment.
Because you see, at the moment, I'm giving confluentkafka://kafka.kafka.svc.cluster.local to my app. which is ugly when you think about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my local & confluent tests, the same transport class can be used for both
confluentkafkaandkafkaitself. I've done countless tests and it works.Based on the works on #1506