Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate utils/amp_manager.py #1553

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

khanh96le
Copy link

Related to #1511

@lgtm-com
Copy link

lgtm-com bot commented May 30, 2022

This pull request introduces 1 alert when merging a77761c into 0a2f54e - view on LGTM.com

new alerts:

  • 1 for Unused import

@khanh96le khanh96le marked this pull request as draft May 30, 2022 14:25
@khanh96le khanh96le changed the title Annotate utils amp manager Annotate utils/amp_manager.py May 31, 2022
@khanh96le khanh96le marked this pull request as ready for review May 31, 2022 06:59
kombu/utils/amq_manager.py Show resolved Hide resolved
Comment on lines +24 to +28
return (
val if val is not None
else opt(
'manager_%s' % name) or getattr(client, name, None) or default
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should keep the diff as small as possible. Please remove this reformatting.

Copy link
Contributor

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also needs to include the name of the file in the mypy file list, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants