Annotate json.py
#1529
Open
Annotate json.py
#1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Thanks @dobosevych ! We need to work a little bit on those I can try to help on those later on, if needed. 🙏 |
for more information, see https://pre-commit.ci
|
@Kludex did one more iteration on this module. It would be great to have some feedback and what can be improved |
Kludex
reviewed
Apr 19, 2022
| datetime=datetime.datetime, | ||
| text_t=str): | ||
| def default(self, o: Any, | ||
| dates: Iterable = (datetime.datetime, datetime.date), |
There was a problem hiding this comment.
We can do: DateType = TypeVar("DateType", bound=datetime.date) here.
| text_t=str): | ||
| def default(self, o: Any, | ||
| dates: Iterable = (datetime.datetime, datetime.date), | ||
| times: Iterable = (datetime.time,), |
There was a problem hiding this comment.
Analogous as above, I guess? Please confirm.
| times: Iterable = (datetime.time,), | ||
| textual: Any = (decimal.Decimal, uuid.UUID, DjangoPromise), | ||
| isinstance: Callable = isinstance, | ||
| datetime: Type[datetime.datetime] = datetime.datetime, |
There was a problem hiding this comment.
Tricky... Maybe Type[DatetimeType], being DatetimeType = TypeVar("DatetimeType", bound=datetime.datetime)?
| textual: Any = (decimal.Decimal, uuid.UUID, DjangoPromise), | ||
| isinstance: Callable = isinstance, | ||
| datetime: Type[datetime.datetime] = datetime.datetime, | ||
| text_t: Callable[[Any], str] = str) -> Union[str, Dict]: |
There was a problem hiding this comment.
Not sure about this union... 🤔
| dates: Iterable = (datetime.datetime, datetime.date), | ||
| times: Iterable = (datetime.time,), | ||
| textual: Any = (decimal.Decimal, uuid.UUID, DjangoPromise), | ||
| isinstance: Callable = isinstance, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part of #1511