Fix setDragDisable for multiple grids #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change how setDragDisable works to support multiple grids on one page with different drag settings for each grid.
skrajewski
reviewed
Jan 31, 2017
There was a problem hiding this comment.
Hi @crazyjat,
Thank you for your contribution! I'm glad that someone is willing to improve this plugin :) I have done a review for you. It will be nice if you fix it because it doesn't work as expected.
Kind regards,
Szymon
| @@ -145,7 +139,7 @@ | |||
| }, | |||
|
|
|||
| onDragStartEventListener: function(e) { | |||
| if (uiGridDraggableRowsSettings.dragDisabled || (hasHandle && !handle)) { | |||
| if (this.dragDisabled || (hasHandle && !handle)) { | |||
There was a problem hiding this comment.
this in this place is DOM node
| var publicMethods = { | ||
| dragndrop: { | ||
| setDragDisabled: function setDragDisabled(status) { | ||
| uiGridDraggableRowsSettings.dragDisabled = ~~status; | ||
| this.dragDisabled = ~~status; |
There was a problem hiding this comment.
this in this place is single grid object, but in my opinion, it's better to keep dragDisabled state inside the plugin instead of performing modification in main grid itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how setDragDisable works to support multiple grids on one page with different drag settings for each grid.