Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a corner case when depicting cc(C)c #1059

Merged
merged 1 commit into from Mar 15, 2024
Merged

Fix a corner case when depicting cc(C)c #1059

merged 1 commit into from Mar 15, 2024

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Mar 15, 2024

Fixes #1057

Note @JonasSchaub this is bending the rules of what the depictor is meant to do. It's an invalid SMILES string and so it can't really many anything.

Example of what it now does below:

@johnmay
Copy link
Member Author

johnmay commented Mar 15, 2024

Screenshot 2024-03-15 at 14 47 12

Copy link

sonarcloud bot commented Mar 15, 2024

@JonasSchaub
Copy link
Contributor

Note @JonasSchaub this is bending the rules of what the depictor is meant to do. It's an invalid SMILES string and so it can't really many anything.

Thanks a lot @johnmay for "bending the rules" this way for my use case. I've also checked the fix for bigger cases I encountered, like "cc(-c1ccccc1)c(c2ccccc2)C", and it works fine there as well. Thank you!

@egonw egonw merged commit 267f3b6 into main Mar 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug in DepictionGenerator aromatic display
3 participants