New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of sugar moiety removal functionality #1040
base: main
Are you sure you want to change the base?
Conversation
Thanks for the updates, I'm quite busy this week/early next but will do an in depth check end of next week. Overall from first glance it looks good and should be OK to merge reasonably quickly - I added one comment about the IPseudoAtom - but Symbol=R is also OK. |
This one I am less fussy about but some bits are similar:
|
@johnmay sorry for dropping the ball on this here; I will make the requested changes soon! Thanks for the initial review. |
Should just be to merge PR I sent you? |
Then it's good to go |
The PR you sent me is for the functional groups functionality. Good that you mention that because I haven't seen it before (incorrect "watch" settings on my fork, I'm very very sorry). Will get to that as well as soon as possible! |
Oh right sorry yes, moving house next week so things are all going 100kph ATM. |
Good luck with that, hope it's going well! |
Reference issue: #854