Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @johnmay, assuming I get that minor CDK grant, I need to be prepared to get started. So, I'm going to get some routine back. How beter than with code clean up.
This small patch is just to get some feedback. I want to remove all remaining hard-coded dependencies on the
cdk-data
implementation. In doing so, I also moved one test class into theextra
module itself. There was a technical reason, being the dependency on abstract test class. Are you happy with moving test class that do not have that dependency into the main module, because then some will be, others will not?Another perhaps controversial thing is that it copies code from the
ElectronContainer
andChemObject
classes, to provide the fullIElectronContainer
API.Let met me know what you think. This PR is also about the discussion and happy if you cherrypick and/or tell me to extract bits and exclude other bits.