Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if the ancestor has [mousetrap] classname #423

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check if the ancestor has [mousetrap] classname #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64d48bb
fixed the target's parent has 'mousetrap'
CraigZeng Jun 4, 2018
479c751
Merge pull request #1 from CraigZeng/CraigZeng-check-parents
CraigZeng Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion mousetrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,16 @@

return _belongsTo(element.parentNode, ancestor);
}

function _parentHas(element, cls) {
if(element === null) {
return false
}
if ((' ' + element.className + ' ').indexOf(' ' + cls + ' ') > -1) {
return true
}
return _parentHas(element.parentNode, cls)
}

function Mousetrap(targetElement) {
var self = this;
Expand Down Expand Up @@ -974,7 +984,7 @@
var self = this;

// if the element has the class "mousetrap" then no need to stop
if ((' ' + element.className + ' ').indexOf(' mousetrap ') > -1) {
if (_parentHas(element, 'mousetrap')) {
return false;
}

Expand Down