New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting bios.shell_path #1795
base: mc-1.20.x
Are you sure you want to change the base?
Conversation
Allow the user to directly set the path the bios uses for the shell. Has some additional status checking to allow for shell errors to be read before computer shutdown.
I learned how to lintLua!
The utility for me is that I don't have to deal with my own shell (or programs that don't require a shell) being layered atop an existing shell. It just feels like an extra step that should have the ability to be removed, especially when it's dead simple to implement, does not break compatibility, and is entirely up to the user to take advantage of. |
How does the dead shell impacts anything? Assuming multishell is off and you called EDIT: I guess it is there in call stack but does that really impact anything ? |
Startup programs wouldn't even be ran, and the shell API would not exist. Those are both things the shell does. Basically any EDIT: |
Extracts os.run into an internal launch function so we can extract shell errors and correctly display them on the native terminal.
Allows the user to directly set the path the bios uses to launch the shell. Setting
bios.shell_path
takes precedent overbios.use_multishell
. Essentially a custom shell may choose to implementshell
andmultishell
APIs, independent of whether use_multishell is set. This is loosely reflected in the description of the setting. Also some additional status checking has been implemented to allow for shell errors to be easily read before computer shutdown.My justification for adding this is that while unbios exists, it is the logical extreme of what I imagine most players want. This PR is the spirit of unbios in a way that makes sense for CC, that advanced players can take advantage of (if I'm not mistaken mbs could benefit from this too, no?) Also servers presumably would ever so slightly benefit from computers that don't need a whole shell having the ability to start without one.