Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Search #893

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Text Search #893

wants to merge 6 commits into from

Conversation

iddan
Copy link
Collaborator

@iddan iddan commented Nov 21, 2019 •
edited

MVP implementation of text search based on Bleve. There are many capabilities not included in this PR but anything beyond the basic text search should be added in additional PRs.

Resolves #428

Tasks

  • For KV stores, Implement Bleve's KV Store instead of creating a file.
  • Update data model to create single property Bleve documents
  • Hook up search.Index() and search.Delete() for quads write and delete
  • Hook up search configuration to Cayley configuration
  • Hookup search.Configuration to Cayley config file (and CLI?)
  • Documentation:
    • Tutorial
    • Detailed documentation of configuration options

This change is Reviewable

@iddan iddan requested a review from dennwc November 21, 2019 11:49
@iddan iddan self-assigned this Nov 21, 2019
@iddan iddan added this to the v0.8.0 milestone Nov 23, 2019
@iddan iddan changed the title Full Text Search Text Search Nov 23, 2019
@iddan iddan marked this pull request as ready for review November 24, 2019 10:45
@iddan
Copy link
Collaborator Author

iddan commented Nov 30, 2019

Bleve will only be implemented for in-memory and key-value backends for now.

dennwc
dennwc requested changes Dec 13, 2019
View reviewed changes
graph/kv/indexing.go Outdated Show resolved Hide resolved
graph/kv/iterators.go Show resolved Hide resolved
graph/kv/iterators.go Outdated Show resolved Hide resolved
graph/kv/quadstore.go Outdated Show resolved Hide resolved
server/search/search.go Outdated Show resolved Hide resolved
server/search/search.go Outdated Show resolved Hide resolved
server/http/api_v2.go Outdated Show resolved Hide resolved
@dennwc dennwc force-pushed the feature/search branch 3 times, most recently from 0056828 to 640ea2e Compare December 15, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennwc dennwc dennwc requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@iddan iddan

Labels
Feature Design
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Text Search
2 participants
@iddan @dennwc