added missing initialization of D buffer in 2mm #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialization of the D buffer used for the GPU kernel was missing.
The GPU (and also the CPU) version adds values to the D buffer:
D[i * nl + j] += tmp[i * nj + k] * C[k * nl + j];
This means the initial values of D does matter for the computation. The D buffer of the CPU versions get initialized in the init_array function, but the GPUs D buffer initialization was missing.
This has only a very small impact on the result (and performance) and is therefore not detected by the compareResults function.