Fix build on ARM64EC #2858
Merged
Fix build on ARM64EC #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2858 +/- ##
==========================================
+ Coverage 91.09% 91.10% +0.01%
==========================================
Files 197 197
Lines 8382 8382
==========================================
+ Hits 7635 7636 +1
+ Misses 747 746 -1 |
|
I played around with the pragma a bit on compiler explorer, and I think that the best solution is to just remove it completely. |
added 2 commits
April 18, 2024 13:51
This reverts commit 7a4f6d7.
Remove `#pragma intrinsic(_umul128)` because it doesn't work on ARM64EC and x64 works without it.
|
I removed the pragma bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build break due to
#pragma intrinsic( _umul128 )on ARM64EC. This intrinsic only exists on x64. However, ARM64EC builds also define_M_X64so the#pragma intrinsicneeds to be excluded on those.