Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add Feature] View docs in a more comfortable way #2478

Closed
wants to merge 16 commits into from

Conversation

ryankert01
Copy link

Description

When I'm reading the documentation, I felt a bit uncomfortable when traveling between files.
So I think I can change that by using a static website generator. In this case, I pick vitepress, which is a framework that specifies with writing documentation on various Github Projects.

You can see the final work on :
https://ryankert01.github.io/Catch2/

I think it is pretty nice with the look and the experience and can potentially attract more users.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #2478 (ec98362) into devel (4adf010) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #2478      +/-   ##
==========================================
+ Coverage   91.54%   91.55%   +0.01%     
==========================================
  Files         183      183              
  Lines        7561     7561              
==========================================
+ Hits         6921     6922       +1     
+ Misses        640      639       -1     

@adehad
Copy link

adehad commented Sep 5, 2022

I think you may want to update the .gitignore !

e.g. docs/dist/ and node_modules

@ryankert01
Copy link
Author

updated that

@adehad
Copy link

adehad commented Sep 6, 2022

Nice, don't forget to remove the files currently committed in those locations.
That should remove around 1million lines from this pull request!

@ryankert01
Copy link
Author

deleted node_modules and docs/.vitepress/dist

Copy link

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope these changes help get this PR approved

yarn-error.log Outdated Show resolved Hide resolved
docs/release-notes.md Outdated Show resolved Hide resolved
docs/matchers.md Outdated Show resolved Hide resolved
@LecrisUT
Copy link
Contributor

There is also #2672 competing for this, and I believe sphinx is more standard. Want to discuss this in #2709 ?

@LecrisUT LecrisUT mentioned this pull request Jun 26, 2023
3 tasks
@ryankert01 ryankert01 closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants