Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more mimetypes the the report: video, image, H5P #479

Open
wants to merge 1 commit into
base: DEPRECATED_master
Choose a base branch
from

Conversation

nadavkav
Copy link

Add a few more useful mimetypes to the objectfs sync status report: images, videos, H5P

@nadavkav
Copy link
Author

@brendanheywood How about this?

@brendanheywood
Copy link
Contributor

@nadavkav this pr is against a deprecated branch

Also can you put in some more detail around how to test and what this is doing? I already see both image and video in the mimetype reports. H5p is not there and would be useful.

Also fyi I'm gonna be off to the moot shortly and then on leave for a month

@nadavkav
Copy link
Author

nadavkav commented Sep 12, 2022

@brendanheywood looking forward to meet with you at the global moot :-)

@caiovncius
Copy link

Any news about this release?

@danmarsden
Copy link
Member

@caiovncius feel free to help by copying the patch and applying the changes Brendan suggests in his comment above and submit a new PR with the changes - otherwise this will likely sit here until nadav comes back to it.

@nadavkav
Copy link
Author

We are still using your old version, and will not update our code with your new release soon,
so I do not have an updated version of this patch, thought I hope the code in that area did not change much,
and also hope you can apply it easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants