Add Pin::DelegatedMethod #602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grncdr
force-pushed
the
delegated-method-pin
branch
from
5f61085
to
21db866
Compare
|
@castwide not sure if you get notified for draft PRs, but I would definitely appreciate your thoughts on this one before moving forward. |
|
Sorry for the long delay. This looks like a solid start. It might also be useful for implementing proper support of the |
grncdr
force-pushed
the
delegated-method-pin
branch
2 times, most recently
from
0a98ee7
to
e961c1c
Compare
grncdr
force-pushed
the
delegated-method-pin
branch
from
930a66b
to
76d902c
Compare
This is a more complicated version of a method alias, where the type of the method receiver can be resolved dynamically using a Source::Chain. As hinted at by the name, this allows creating pins that fully support the `Module.delegate` method from ActiveSupports core extensions.
grncdr
force-pushed
the
delegated-method-pin
branch
from
76d902c
to
145618b
Compare
|
Hi @castwide, I've just rebased my branch on the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more complicated version of a method alias, where the type of the method receiver can be resolved dynamically using a Source::Chain.
The idea didn't get much of a response in #591, but I really wanted to implement proper support for the
Module.delegatemethod from ActiveSupport. You can see how it's used in my solargraph-rails work here.I'd really like to get this merged, and I'm happy to add specs for it, but I want to get feedback on the implementation, as it's a pretty "unusual" pin type.