Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Editor Theme Change with Windows Theme (Dark/Light) #555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0x4A4D00
Copy link

Using this Package We can use Dark/Light Theme on Windows.

Metadarkstyle Package needs to be installed on Lazarus.
Maybe It's better to change the color of the editor buttons' images a little.

_gameviewplay castle-user-interface  test-3 _ Castle Game Engine 12_14_2023 2_24_44 PM

@michaliskambi
Copy link
Member

michaliskambi commented Dec 14, 2023

Interesting, thank you! The modification to CGE editor is very small, so it may make sense. (In the past I was reluctant to add to CGE editor some "heavy" code modifications, that would only give us dark mode, and were usually not-cross-platform. This is also not cross-platform, but the modification is admittedly very small, not a problem to maintain.)

Note that we'd have to distribute https://github.com/zamtmn/metadarkstyle along with CGE to make it available out-of-the-box. Experience shows that each time we add a new package as dependency, it has to be in packages/ so that compilation works "out of the box" for everyone.

I'll test and think. Thank you!

@0x4A4D00
Copy link
Author

I'm glad it was useful!

As far as I know, programs like CGE and Lazarus, on various operating systems such as Linux distributions, macOS, and various BSDs(I worked with CGE on OpenBSD), synchronize their themes with the operating system and desktop environment. This issue is only present within Windows.

Additionally, using this package, you might be able to use Qt instead of WinForms with a dark theme on Windows and also other platforms.

Anyway, do I need to make any changes or add something to this pull request now?

@michaliskambi
Copy link
Member

Anyway, do I need to make any changes or add something to this pull request now?

No, it's good. I need to test it and decide, it's on me :)

How to include https://github.com/zamtmn/metadarkstyle in CGE repo -- I'll also see the best way to do this. Then the CI (GitHub Actions / Jenkins) will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants