Make export to UVFits work with non-constant receptor angles #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented by Dirk Petry Fixes #1340
|
@tammojan , looks like the MacOS failure is not related to the actual code change ... |
Agree. Not the first time we have to babysit the MacOS build. In the meantime, this build failure should not delay fixing your issue. Do you have a volunteer to review this change? |
|
@kettenis , hi, would you mind reviewing this little adjustment? It downgrades the reaction to a potential problem |
|
@tammojan , not sure if Mark (Kettenis) is actually entitled to do a review. Is he? If not, could you pick a different reviewer? |
dpetry
requested review from
aroffringa and
apschoenmakers
and removed request for
aroffringa
| } | ||
| catch (const std::exception& x) { | ||
| os << LogOrigin("MSFitsOutput", __func__) | ||
| << LogIO::WARN << "Receptor Angles in FEED table are not constant for antenna " << antnum |
apschoenmakers
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented by Dirk Petry (@petry)
Fixes #1340