do not convert links to markdown data files to html #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up in carpentries/lesson-transition#60 where they use a markdown file as data for regex. When I made the links local, these were being converted to HTML. This will fix that situation.
zkamvar
added a commit
to carpentries/lesson-transition
that referenced
this pull request
May 2, 2023
This buys me some time to make sure carpentries/sandpaper#447 will not break a lot of things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent links to markdown files under
episodes/datafrom being converted to HTML.This issue was found in carpentries/lesson-transition#60 where the lesson uses a markdown file as data. Transforming the link from a link to the github repository to a relative link cause it to accidentally transform to HTML.