Corrected information that Sensor.is_listening is (currently) a method #7439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
carla.Sensor.is_listening
is defined twice (since #6013) the <0.9.14 property is overwritten with a method; can also be seen in the DocsThis PR removes the overwritten property and updates the doc, keeping the 0.9.14+ method version in tact.
carla/PythonAPI/carla/source/libcarla/Sensor.cpp
Lines 29 to 31 in f22d49d
Where has this been tested?
Possible Drawbacks
None.
Future work, make it a property again?
I at least would prefer function names like
is_listening
as a property. On one side, it would break the current 0.9.14/15 compatibility, on the other it would restore the one from <0.9.13 which still is found in code more often.So we might want to shift the three Sensor.is_... functions to a property.