navigation information is now loaded when changing maps #7200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
AreopagX
force-pushed
the
areopagx/navigation-bugfix
branch
from
fdde2ca
to
7b7becc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously it was the case that when new maps are loaded, the navigation information from the old map is retained. That was due to the Episode object not being replaced. This led to unexpected behavior, e.g., pedestrians being spawned in inappropriate locations for a map.
Fixes #7195
Where has this been tested?
Possible Drawbacks
I verified that the destructor of the Episode object is called, yet I'm not sure if there are further complications related to resetting this pointer.