Fix waypoints next and previous when connecting two lines with opposite directions #7137
+34
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirrections. Fixing issue carla-simulator#7136 Probably not the best solution, but works for our case. The waypoint that would cause conflict when calling next from it is not returned.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
matejm42
changed the title
wentasah
reviewed
Feb 8, 2024
Co-authored-by: Michal Sojka <michal.sojka@cvut.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing issue #7136 - detailed description there
Fix waypoints next and previous when connecting two lines with opposite directions.
Probably not the best solution, but it works for our case. The waypoint that would cause conflict when calling next from it is not returned.
Where has this been tested?
Possible Drawbacks
Loading maps and getting waypoints from long distances can be a bit slower. However I did not experience any decrease in performance in my case.
You can not get the next waypoint, if calling next from that waypoint would cause a loop. (We found this situation only on curbs connecting two lanes in opposite directions. In this case, it makes sense for us to behave as if the curbs are not connected together. Hopefully, there are no opposite-direction driving lanes connected together.