Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Update radar data #6313

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Dev: Update radar data #6313

wants to merge 6 commits into from

Conversation

Gritslav
Copy link

@Gritslav Gritslav commented Mar 15, 2023

Description

The speed data that is transmitted from the radars has been updated. In the current version, one speed component was issued, which was calculated as the scalar product of the relative velocity vector of the hitted actor and the direction vector per actor. In the new version, the speed is divided into components along the axes Ox and Oy of the radar. The speed is considered relative to the radar.

Where has this been tested?

  • Platform(s): Windows 10
  • Python version(s): 3.8
  • Unreal Engine version(s): 4.26

Possible Drawbacks

Carla may no longer be supported by the current version of ros-bridge.


This change is Reviewable

@Gritslav Gritslav requested a review from a team as a code owner March 15, 2023 06:27
@stale
Copy link

stale bot commented Jun 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had recent activity label Jun 1, 2023
V.Y *= TO_METERS;


// Для дебага!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove comments in other languages than English?

@stale stale bot removed the stale Issue has not had recent activity label Mar 25, 2024


// Для дебага!
//UE_LOG(LogTemp, Warning, TEXT("Vf: %s"), *DV.ToString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you delete commented code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it

@Blyron
Copy link
Contributor

Blyron commented Mar 25, 2024

Hello! Could you resolve Radar.cpp conflicts and comments?

Comments in another language and commented code have been removed
@Blyron
Copy link
Contributor

Blyron commented Apr 10, 2024

There are two conflicts there still

@Gritslav
Copy link
Author

There are two conflicts there still

I think I fixed the conflicts, but I clicked the merge button without thinking. Do I understand correctly that nothing critical happened, and my changes were saved in the repository?

@Blyron
Copy link
Contributor

Blyron commented Apr 11, 2024

Your changes are there still, could you update the backlog and then the PR would be ready to go in

@Gritslav
Copy link
Author

Did I understand correctly that I need to make a description of my changes to the file CHANGELOG.md ? If so, how to arrange it correctly? Just add a line to the list of recent updates?

@Blyron
Copy link
Contributor

Blyron commented Apr 15, 2024

Yeah, that's it add a line commenting this. Many people will read and maybe this will be affecting their code

@Blyron Blyron self-assigned this Apr 15, 2024
@Blyron
Copy link
Contributor

Blyron commented Apr 26, 2024

Hello,

We have been looking at your PR. We want to keep the previous version of velocity. You could add your velocity y and x on top of that. For now we are not merging your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants