Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Telemetry Data #5153

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Expose Telemetry Data #5153

wants to merge 5 commits into from

Conversation

joel-mb
Copy link
Contributor

@joel-mb joel-mb commented Feb 9, 2022

Description

This PR exposes the telemetry data to the client:

vehicle.get_telemetry_data()

This will return a VehicleTelemetryData structure with the following information

VehicleTelemetryData(
    speed  # [m/s]
    steer
    throttle
    brake
    engine_rpm
    gear
    drag  # [N]
    wheels  # list of WheelTelemetryData
)
WheelTelemetryData(
    tire_friction
    lat_slip  # [degrees]
    long_slip
    omega
    tire_load
    normalized_tire_load,
    torque  # [Nm]
    long_force  # [N]
    lat_force  # [N]
    normalized_long_force
    normalized_lat_force
)

Where has this been tested?

  • Platform(s): Ubuntu 18.04
  • Python version(s): 3.7
  • Unreal Engine version(s): 4.26

Possible Drawbacks


This change is Reviewable

@joel-mb joel-mb requested a review from a team as a code owner February 9, 2022 16:57
jackbart94
jackbart94 previously approved these changes Feb 10, 2022
Copy link
Contributor

@jackbart94 jackbart94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Axel1092)


Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp, line 787 at r1 (raw file):

    Wheels.Add(WheelTelemetryData);
  }
  

tab

Copy link
Contributor Author

@joel-mb joel-mb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Axel1092)


Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Vehicle/CarlaWheeledVehicle.cpp, line 787 at r1 (raw file):

Previously, jackbart94 (Jacopo Bartiromo) wrote…

tab

Done

* Exposed omega instead of rpm
* Added tire_load, normalized_long_force, normalized_lat_force
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had recent activity label Apr 16, 2022
@stale stale bot closed this Apr 28, 2022
@bernatx bernatx reopened this May 5, 2022
@stale stale bot removed the stale Issue has not had recent activity label May 5, 2022
@Himverma2012
Copy link

Hi, I was able to implement this code for my project & I'm able to use the command

telemetry = world.player.get_telemetry_data

Inside this, I get a structure like you've mentioned & I can access the VehicleTelemetryData using operator. But when I try to get the WheelTelemetryData using telemetry.wheels (I'm a noob, I know), I get an error:

TypeError: No to_python (by-value) converter found for C++ type: class std::vector<class carla::rpc::WheelTelemetryData,class std::allocator<class carla::rpc::WheelTelemetryData> >

Can you help me with this issue?

@stale
Copy link

stale bot commented Jun 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had recent activity label Jun 1, 2023
@Akshay-sudo-ux
Copy link

Hi, is there a plan to merge this PR to dev? The telemetry info exposed here to the client is pretty useful.

Thanks in advance,
Akshay

@stale stale bot removed the stale Issue has not had recent activity label Aug 18, 2023
Copy link

stale bot commented Dec 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had recent activity label Dec 21, 2023
@stale stale bot removed the stale Issue has not had recent activity label Apr 23, 2024
Copy link
Contributor

@Blyron Blyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 16 files at r1, 4 of 4 files at r2.
Reviewable status: 4 of 16 files reviewed, all discussions resolved (waiting on @Axel1092 and @jackbart94)

Copy link
Contributor

@Blyron Blyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Axel1092)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants