Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Establishing a New Connection in Connect Wallet #462

Merged
merged 22 commits into from May 13, 2024
Merged

feat(ui): Establishing a New Connection in Connect Wallet #462

merged 22 commits into from May 13, 2024

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented May 9, 2024 •
edited

Description

  • Establishing a new connection in Connect Wallet.
  • Fix UI style for edit identifier modal

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-822

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Screen.Recording.2024-05-13.at.17.05.50.mov
Screenshot 2024-05-09 at 14 10 28

Android

Screen.Recording.2024-05-13.at.17.16.13.mov

Screenshot 2024-05-09 at 14 05 08

Browser

Screen.Recording.2024-05-13.at.16.55.14.mov

Screenshot 2024-05-09 at 14 11 32

@Sotatek-DukeVu Sotatek-DukeVu self-assigned this May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-q4kxgna5y.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-jrjvx1bv0.vercel.app

Vu Van Duc added 13 commits May 10, 2024 13:54
feat(ui): implement disconnect actived connection alert when create n…
d13196b 
…ew connection and alert user when connect wallet with empty identifier
feat(ui): implement paste connection peer id modal
d528761
feat(ui): implement connect wallet incomming request
ec5ca6f
feat(ui): update scanner
da7316c
feat(ui): apply establishing new wallet connection flow for connect w…
051bf16 
…allet
fix(ui): fix style for scanQR button
b5d6593
fix(ui): fix style for edit identifier
7b0abac
feat(ui): remove add connection modal
c208bfe
feat(ui): remove verify pin/password action when connect wallet
9a90087
feat(ui): create pending connection in redux
8a59526
feat(ui): move connect wallet request to outside incoming request com…
c840f0b 
…ponent
feat(ui): update UI for establishing new connection wallet
6aa8048
feat(ui): update translate file and move to component
f6742c7
@Sotatek-DukeVu Sotatek-DukeVu force-pushed the feature/DTIS-822-establishing-new-connection-connect-wallet branch from 6e18b1a to f6742c7 Compare May 10, 2024 07:25
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-6hh88inqt.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-5mj9nrn0j.vercel.app

@Sotatek-DukeVu
Copy link
Collaborator Author

Disable confirm when pid input empty. This commit not update UI then I think I should capture

Screen.Recording.2024-05-10.at.16.27.29.mov

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-ia1wu06tk.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-apmskyzj8.vercel.app

sdisalvo-crd
sdisalvo-crd requested changes May 10, 2024
View reviewed changes
src/ui/App.tsx Show resolved Hide resolved
src/ui/App.tsx Outdated Show resolved Hide resolved
src/ui/components/PageFooter/PageFooter.scss Outdated Show resolved Hide resolved
src/ui/components/PasteConnectionPeerIdModal/PasteConnectionPeerIdModal.scss Outdated Show resolved Hide resolved
src/ui/components/Scanner/Scanner.scss Outdated Show resolved Hide resolved
src/ui/components/WalletConnectRequest/WalletConnectRequest.scss Outdated Show resolved Hide resolved
src/ui/components/WalletConnectRequest/WalletConnectRequest.tsx Outdated Show resolved Hide resolved
src/ui/components/layout/ResponsivePageLayout/ResponsivePageLayout.scss Outdated Show resolved Hide resolved
src/ui/globals/types.ts Outdated Show resolved Hide resolved
src/locales/en/en.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-nmob7dpve.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-5xzq05i81.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-13wz3zbs9.vercel.app

@sdisalvo-crd sdisalvo-crd merged commit d1dacd3 into develop May 13, 2024
2 checks passed
@sdisalvo-crd sdisalvo-crd deleted the feature/DTIS-822-establishing-new-connection-connect-wallet branch May 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdisalvo-crd sdisalvo-crd sdisalvo-crd approved these changes

Assignees

@Sotatek-DukeVu Sotatek-DukeVu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sotatek-DukeVu @sdisalvo-crd