Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elements): reconfigure elements previews next config #16472

Merged

Conversation

tay1orjones
Copy link
Member

I think this should fix the elements previews - they're currently failing because of this piece we missed when reviewing the dependabot/renovate PRs updating nextjs from 13 -> 14

Changelog

Changed

  • update nextjs config to use output: 'export'

Removed

  • no longer use next export

Testing / Reviewing

  • In theory the elements netlify deploy preview should work on this PR, though I'm not sure. Might have to merge this and watch the production deployment in netlify to see if it works properly.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 47dfa80
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6643c2d1a076f5000859683e
😎 Deploy Preview https://deploy-preview-16472--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 47dfa80
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6643c2d19abc3000081f19f8
😎 Deploy Preview https://deploy-preview-16472--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@guidari guidari added this pull request to the merge queue May 17, 2024
Merged via the queue into carbon-design-system:main with commit 3c47c9b May 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants