Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft commit for review for Popover v11 #1896 #1930

Open
wants to merge 1 commit into
base: next/v11-styles
Choose a base branch
from

Conversation

SimpleProgrammingAU
Copy link
Contributor

@SimpleProgrammingAU SimpleProgrammingAU commented Mar 8, 2024

I spent a couple hours adopting the CDS React approach to the Popover element and it appears to break the previously working approach in CDS Svelte (i.e. without providing a PopoverContent component).

Please have a quick look at what I've done and let me know if we should lean into what looks like a very breaking change or have I missed something that would allow the existing syntax, as shown in the current CDS Svelte documentation, to work?

Implemented:

  • added id prop (although, I added that months ago and am now wondering if I added that correctly)
  • added dropShadow option
  • added containerProps object
  • removed references to the relative prop because it looks like that's forced upon you now (or am I misreading the css?)
  • amended container to a span element rather than a div per CDS React
  • added contentProps to PopoverContent
  • amended documentation for new syntax

Not yet implemented:

  • tabTip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant