Breaking: Move $$restProps in Select from wrapper <div> to <select>
#1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the component with others like `TextInput`, `NumberInput` or `TextArea` and allows adding not explicitly defined attributes to the "main" element of the component. Other changes are from formatting by `lint` task. (Prettier removes manual line breaks via ` ` from JSDoc strings; turned that into paragraph in `Header`.)
metonym
force-pushed
the
master
branch
2 times, most recently
from
e7485c4
to
417102d
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the component with others like
TextInput,NumberInputorTextAreaand allows adding not explicitly defined attributes to the "main" element of the component. Unfortunately there is no real equivalent forDropDown, which is non-standard.Maybe there could be a standardized property that exists on all inputs (like
ref) for adding attributes on the root wrapper via spread, the main use case for me would be to apply layout classes to e.g. add margins.Other changes are from formatting by
linttask.(Prettier removes manual Markdown line breaks (two trailing spaces) from JSDoc strings; turned that into paragraphs in
Header.)