NumberInput : Fix error states #1584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et the `error` accordingly. 2. Fix last commits and the `invalid` state border works again. 3. If the `invalid` state is set by the user, we must use `setCustomValidity` to set input validity to false. 4. `invalidText` must have a default and must not be empty. If empty, it will set the validity to true. I don't know if we should check for that.
is now binded to the input. Required, min, max and value are reative to error states.
|
Last commit is a big step forward. |
metonym
force-pushed
the
master
branch
2 times, most recently
from
e7485c4
to
417102d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowEmptyattribute torequired.allowEmptymakes no sense, it should always berequiredto match baseHTML inputatrributes.invalid statewith a red outline and the validity of the input would stayvalid(only if empty). This patch fix this.** NOTE TO DISCUSS : This bug was caused by the ambiguity between
invalidanderrorvariables. I think that we need to remove theexport invalidand let it be local only. If OP wants to validate the input, we can export thepatternor change thesetCustomValiditywith theref. Since this PR check the validity of the input oninputandchange, thesetCustomValiditywill set the error.** Edit : I forgot to link the issue #1583 . -_-