Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port OCaml bindings to use Dune and Opam #2319

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

XVilka
Copy link
Contributor

@XVilka XVilka commented Apr 9, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Test plan

  • CI is green
  • opam install .
  • dune test

Closing issues

Closes #985

@XVilka
Copy link
Contributor Author

XVilka commented Apr 9, 2024

There is still missing proper testing, I think I will just write a proper tests, that will compare the output with the expected, and will add the testing step to the CI.

@Rot127
Copy link
Collaborator

Rot127 commented Apr 10, 2024

There is still missing proper testing, I think I will just write a proper tests, that will compare the output with the expected, and will add the testing step to the CI.

Yes, for now this is enough. But at minimum the build should added in the CI.

@Rot127 Rot127 added AArch64 Arch ocaml bindings build & packaging Build system and packaging related labels Apr 10, 2024
@Rot127 Rot127 added this to the v6 milestone Apr 10, 2024
@strub
Copy link

strub commented May 7, 2024

Hi. Against which version of capstone this binding should be compiled? The OCaml stub does not seem in sync with the Capstone API as found in the branch the OCaml stub belongs to.

@strub
Copy link

strub commented May 7, 2024

The bindings build correctly with Capstone 5.0.1.

@XVilka
Copy link
Contributor Author

XVilka commented May 7, 2024

Hi, it's still in progress. I am targeting 6.0. I still need to implement missing architectures support that were added since the last time OCaml bindings were touched. I also plan to add proper testing with alcotest. Moreover, the auto-sync scripts should be extended to auto-regenerate constants so that they are in sync with the C version. Once everything is done, I also plan to package it for opam and send PR to the opam-repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AArch64 Arch build & packaging Build system and packaging related ocaml bindings
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Add capstone to OPAM
3 participants