Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App Helper - Project Management #888

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

matbgn
Copy link
Contributor

@matbgn matbgn commented Mar 23, 2023

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

I think this project is so well maintained, and we lack of such good solution on Caprover, that I hope you will accept this PR @githubsaturn

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.

@githubsaturn
Copy link
Collaborator

githubsaturn commented Mar 24, 2023

Thanks, @matbgn for the PR.

But as far as I can tell, this is a personal project with just a 200 stars and even more concerning, just 62 Docker image pulls.

Can you please provide more context why this app needs to be in the official repo of one click apps? (since it doesn't pass our minimum threshold).

image

@matbgn
Copy link
Contributor Author

matbgn commented Mar 24, 2023

I know that this situation is exceptional. But based on my experience with Caprover and as a professional Scrum Master, I can guarantee that there are not so many applications of this kind, with this level of sophistication, on the open source market (maybe only Taiga is a solid alternative), and even if the application has some imperfections, the investment put into the development of this project and the active maintenance of the code base make me confident to integrate this project into Caprover.

You are getting to know me a bit and you know that I would not propose anything not viable for Caprover in the medium/long term (last example with ERPNext even if I use it on daily basis right now).

This is of course my own opinion, but as a third party (neither author of Helper nor author of the Caprover source code) who has already contributed quite a bit to the Caprover One-Click-Apps, I am really convinced that this is a real plus that we offer to the community and not just another project.

@gaschenk
Copy link

In regards to running this application, I've been running into the issue that verification mails are not working with the following notification "403 - Signature invalid."

I believe but I'm not certain that the following issue from the application repository might be the primary issue: devaslanphp/project-management#60

In conclusion account creation works, but account verification and following that application usage isn't verifiable.

@matbgn
Copy link
Contributor Author

matbgn commented Mar 31, 2023

Not sure about it, I have successfully deployed Helper on my Caprover instance let me check on my instance

@heloufir
Copy link

Hello,
Yes there is some people running into the same error, I am working on this, I'll let you know ASAP

@matbgn
Copy link
Contributor Author

matbgn commented May 18, 2023

@heloufir any news on this?

@uhlhosting
Copy link

@heloufir seems you got really stuck working on this....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants