Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add pi hole #707

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

LiquidITGuy
Copy link
Contributor

@LiquidITGuy LiquidITGuy commented Sep 1, 2022

First of all, thank you for your contribution! 馃槃

Capture d鈥檈虂cran 2022-09-01 a虁 23 31 45

鈽戯笍 Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • [] I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.

@LiquidITGuy
Copy link
Contributor Author

the deploy works but my docker knowledge with network is too bad to make it works (I can only configure the dns on the local server)
if someone want to continue the pull request to make pihole fully functionnal it will be great

@itxtoledo
Copy link
Contributor

@LiquidITGuy what you need to make this script work? I can help

@LiquidITGuy
Copy link
Contributor Author

@itxtoledo it seems to work but when I tried to use pihole as dns server I'm stucked.
I'm not realy sure about how can I unlock it.

@michelbarnich
Copy link

@itxtoledo it seems to work but when I tried to use pihole as dns server I'm stucked. I'm not realy sure about how can I unlock it.

What exactly do you mean? Are you setting the Server as your only DNS sever on your local machine? Where does it get stuck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants