Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding: Wireguard VPN #1003

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Adding: Wireguard VPN #1003

wants to merge 4 commits into from

Conversation

Duckiduc
Copy link

@Duckiduc Duckiduc commented Oct 19, 2023

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@Duckiduc Duckiduc marked this pull request as draft October 19, 2023 19:25
@Duckiduc
Copy link
Author

Testing Note:

Testing this pull request might be a bit tricky due to the nature of the WireGuard VPN service and my current setup. Here are the details:

  1. Local Testing: Unfortunately, I cannot install CapRover locally on my system, which makes local testing of the WireGuard service within the CapRover environment infeasible.

  2. VPS Environment: I have a WireGuard VPN service running on a VPS using CapRover, and taking it down for testing purposes is not an option, as it would disrupt the existing service for other users.

Given these constraints, I've done my best to ensure that the changes adhere to best practices and have thoroughly reviewed the code. However, I understand the importance of proper testing.

If any other contributors or reviewers have suggestions for overcoming these testing challenges or have specific testing instructions, please feel free to share them. I appreciate your understanding and cooperation in this matter.

Please let me know if you have any questions or need further clarification regarding the changes in this pull request.

@githubsaturn
Copy link
Collaborator

githubsaturn commented Oct 20, 2023

Yes, overall it looks good to me as well! Probably someone can rest and once confirmed to be working, I'm happy to merge!

I don't know wiregaurd workings and what to test, so unfortunately I'm unable to test.

Alternatively, you can ping me on Slack (@kasra) and I get give you a VPS box for a few days to run some tests.

@Duckiduc
Copy link
Author

OK thanks. I am going to try and find a solution to test the VPN. I'll ping you if needed.

FYI here is a list of what I will be testing:

  • Ensure VPN server is up and running
  • Connection to VPS using SSH
  • Test VPN connection from client side using WireGuard client app
  • Data Transfer testing - confirm data is passing through the VPN tunnel
  • IP Leak - Check visible IP address
  • Geo Location Testing - confirm virtual location is that of the VPS
  • Caprover restart - confirm VPN still works as expected
  • Test port prerouting to other caprover apps

@ak4zh
Copy link
Contributor

ak4zh commented Nov 8, 2023

@Duckiduc Have you made any progress on this?

@Duckiduc
Copy link
Author

@Duckiduc Have you made any progress on this?

Not at all. I've been quite busy the last few weeks... didn't have time to properly test it.

@brenner-tobias
Copy link

Great work @Duckiduc, is there an update on this or anything we can support with?

@Duckiduc
Copy link
Author

Duckiduc commented Apr 5, 2024

Great work @Duckiduc, is there an update on this or anything we can support with?

Hey @brenner-tobias! Thanks :) Actually yes I have tested it and it works fine but I won't have the time to maintain it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants