TernaryArrayIOC #812
Open
TernaryArrayIOC #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwbischof
commented
Apr 27, 2023
caproto/ioc_examples/ternaryarray.py
Outdated
|
|
||
| async def general_scan(self, index, group, instance, async_lib): | ||
| # A hacky way to write to the pv. | ||
| await self.pvdb[f'{self.prefix}device{index}_rbv'].write(self._devices[index].state) |
There was a problem hiding this comment.
I think that there might be a way to get rid of this hack. Any ideas?
tacaswell
reviewed
Apr 27, 2023
| self._devices = [TernaryDeviceSim() for i in range(count)] | ||
|
|
||
| # Dynamically setup the pvs. | ||
| for i in range(count): |
There was a problem hiding this comment.
Do this as a helper function that uses type to define a new class. Going up (down?) an abstraction layer will simplify this a a bunch.
There was a problem hiding this comment.
Sounds good, ill try that.
tacaswell
reviewed
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TernaryDevice is a device with 3 states. Many components at a beamline have this behavior. For example, a valve, has an open and close command, a closed state, an open state, and an in-between state.
The TernaryArrayIOC is an IOC that has an array of TernaryDevices.
An example of a device that has an array of ternary devices is an Attenuator, which is an array of filters.
I think an interesting thing about this example is the dynamic pv creation.
Also, I think this is useful to test Ophyd devices like the Attenuator at CMS.
I plan to add an ophyd device here also.