Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize XcodeCapp jakefile #3028

Open
wants to merge 6 commits into
base: narwhal
Choose a base branch
from

Conversation

enquora
Copy link
Contributor

@enquora enquora commented Mar 25, 2022

  • Properly check for macOS versions which use a major version > 10.
  • Clean up minimum/target platform versions - minimum version should now be 10.13 everywhere.
  • Implement separate build and install phases.
  • Build to Cappuccino source folder
  • Install to ~/Applications folder (to avoid problems with elevated permissions in /Applications)
  • Ensure Xcode's modern build system is used for all schemes and targets (legacy build system is deprecated and may be removed without further notices)

…irectory to ~/Applications

With Monterey/Xcode 13, Python 2 is no longer included, python executable doesn't exist.
A temporary solution is to hard-code python3 as the executable - although a separate python3 installation becomes a dependency on earlier platforms.

The Build setting for Installation is changed from /Applications (which requires elevated permissions) to ~/Applications.
* Properly check for macOS versions which use a major version > 10.
* Clean up minimum/target platform versions - minimum version should now be 10.13 everywhere.
* Implement separate build and install phases.
* Build to Cappuccino source folder
* Install to user Applications folder
* Ensure Xcode's modern build system is used for all schemes and targets (legacy build system is deprecated and may be removed without further notices)
…lation directory to ~/Applications"

This reverts commit 39b780b.

Belongs in a separate branch/pull request/patch.
@cappbot cappbot added this to the Someday milestone Mar 25, 2022
@cappbot cappbot added the #new label Mar 25, 2022
@cappbot
Copy link

cappbot commented Mar 26, 2022

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

They are incompatible with the project's top-level Jakefile as it is currently implemented.
Changes to it, and other Jakefiles, are beyond the scope or intent of the current patch.
Changes create a merge conflict with PR 2039.
Change Xcode project settings in following pull request.
@daboe01
Copy link
Contributor

daboe01 commented Apr 1, 2022

-#new
+Tools

@cappbot
Copy link

cappbot commented Apr 1, 2022

Milestone: Someday. Label: tools. What's next? A reviewer should examine this issue.

@cappbot cappbot added tools and removed #new labels Apr 1, 2022
@enquora
Copy link
Contributor Author

enquora commented Dec 22, 2023

See comments for #3029 - this is a work-in-progress, especially determining whether narwhal branch be left as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants