-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize XcodeCapp jakefile #3028
Open
enquora
wants to merge
6
commits into
cappuccino:narwhal
Choose a base branch
from
enquora:modernize-xcodecapp-jakefile
base: narwhal
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
enquora
commented
Mar 25, 2022
- Properly check for macOS versions which use a major version > 10.
- Clean up minimum/target platform versions - minimum version should now be 10.13 everywhere.
- Implement separate build and install phases.
- Build to Cappuccino source folder
- Install to ~/Applications folder (to avoid problems with elevated permissions in /Applications)
- Ensure Xcode's modern build system is used for all schemes and targets (legacy build system is deprecated and may be removed without further notices)
…irectory to ~/Applications With Monterey/Xcode 13, Python 2 is no longer included, python executable doesn't exist. A temporary solution is to hard-code python3 as the executable - although a separate python3 installation becomes a dependency on earlier platforms. The Build setting for Installation is changed from /Applications (which requires elevated permissions) to ~/Applications.
* Properly check for macOS versions which use a major version > 10. * Clean up minimum/target platform versions - minimum version should now be 10.13 everywhere. * Implement separate build and install phases. * Build to Cappuccino source folder * Install to user Applications folder * Ensure Xcode's modern build system is used for all schemes and targets (legacy build system is deprecated and may be removed without further notices)
…lation directory to ~/Applications" This reverts commit 39b780b. Belongs in a separate branch/pull request/patch.
Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue. |
They are incompatible with the project's top-level Jakefile as it is currently implemented. Changes to it, and other Jakefiles, are beyond the scope or intent of the current patch.
Changes create a merge conflict with PR 2039. Change Xcode project settings in following pull request.
-#new |
Milestone: Someday. Label: tools. What's next? A reviewer should examine this issue. |
See comments for #3029 - this is a work-in-progress, especially determining whether narwhal branch be left as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.