-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that the highlight
property is correctly propagated in CPButton. (Was: Update CPButton.
#3004
base: narwhal
Are you sure you want to change the base?
Conversation
Ensure that the `highlight` property is correctly propagated.
Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue. |
AppKit/CPButton.j
Outdated
@@ -548,7 +548,7 @@ CPButtonImageOffset = 3.0; | |||
return; | |||
|
|||
_isHighlighted = shouldHighlight; | |||
|
|||
[super highlight: shouldHighlight]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the space after the colon.
-#new |
@michaelbach can you please fix the formatting issue (space after colon)? |
Milestone: Someday. Label: AppKit. What's next? A reviewer should examine this issue. |
+#ready-to-commit |
Milestone: Someday. Labels: #ready-to-commit, AppKit. What's next? The changes for this issue are ready to be committed by a member of the core team. |
Thank you for your contribution. Before this pr can be merged, we need a better report: what exactly was not working before the pr and what is fixed now. We also need a test (manual in this case) or a path to a test in the repository where the reviewer can verify the change. |
Milestone: Someday. Labels: #needs-ui-test, AppKit. What's next? A reviewer should examine this issue. |
Thank you for looking into it. Before: The getter After: This problem crops up when one codes a custom button. When pressing (but not releasing the button) the state should be visually indicated, and so the info is needed. The problem can be circumvented by using |
Ensure that the
highlight
property is correctly propagated in CPButton. (Was: Update CPButton.j)