fixed: selection and backspace are recently broken in CPTokenField

[daboe01]

this bug was introduced by commit 26aab29
26aab29 was meant to improve iOS experience but makes the tokenfield loose FR status prematurely.
this PR helps CPTokenField to regain FR status after bluring the inputfield by clicking on a token.
it secondly compensates for the backspace event not being propagated anymore in all circumstances
fixes #2795

[cappbot]

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

[daboe01]

-#new
+AppKit
+#needs-review
+regression

[cappbot]

Milestone: Someday. Labels: #needs-review, AppKit, regression. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

[daboe01]

works with FF/chrome/safari, all tested on mac

[daboe01]

found something: clicking between two tokens does not give us a cursor as it should.

[daboe01]

+#needs-improvement

[cappbot]

Milestone: Someday. Labels: #needs-improvement, #needs-review, AppKit, regression. What's next?

• This issue is pending an architectural or implementation design decision and should be discussed or voted on.
• The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon.

[daboe01]

i just tested an old version of cappuccino and it turns out that clicking between two tokens never worked.

-#needs-improvement

[cappbot]

Milestone: Someday. Labels: #needs-review, AppKit, regression. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

[daboe01]

@mrcarlberg would you prefer a runloop approach (not tested though)?

[[CPRunLoop currentRunLoop] performSelector:@selector(makeFirstResponder:) target:[self window] argument:self order:0 modes:[CPDefaultRunLoopMode]]

[cacaodev]

The fix referenced above treats the root of the problem which is that the field should not resign at all its fr when a token element is selected.
TODO: determine what the didBlur listener on the input element was supposed to do and if its removal creates any regression.

[daboe01]

The fix referenced above treats the root of the problem which is that the field should not resign at all its fr when a token element is selected.
TODO: determine what the didBlur listener on the input element was supposed to do and if its removal creates any regression.

i think, that @aljungberg only fixed usability of the touch keyboard of the iPad with 26aab29, that is stopping it from reappearing all the time. I believe he did not test this fix with tokenfield. Therefore, i do not worry so much about the didBlur listener.

[cacaodev]

I should have mentioned that in my patch I did remove the didBlur listener on the tokenfield input element, otherwise it sets again the fr on the tokenfield. But it may have another functionality that i did not figure yet by reading the code.

[daboe01]

-#needs-review
+#needs-improvement

[cappbot]

Milestone: Someday. Labels: #needs-improvement, AppKit, regression. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon.

[daboe01]

@cacaodev i advocate for fixing such a fundamental app-breaking high-level issue asap. we can try a better fix in the future. any objections against merging?