Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Flatten now works with Node.js and JavaScriptCore #2577

Open
wants to merge 1 commit into
base: narwhal
Choose a base branch
from

Conversation

mrcarlberg
Copy link
Member

This is excellent work done by @FrankReh with some small bug fixes by me.

The ToolsTest.j test case will not work now as it has to be run with Node.js

This is excellent work done by @FrankReh with some small bug fixes by me.
@cappbot cappbot added this to the Someday milestone Jan 15, 2018
@cappbot cappbot added the #new label Jan 15, 2018
@cappbot
Copy link

cappbot commented Jan 15, 2018

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@daboe01
Copy link
Contributor

daboe01 commented Apr 12, 2018

milestone=1.0
@mrcarlberg can you have a look why travis fails?
+#needs-improvement

@mrcarlberg
Copy link
Member Author

mrcarlberg commented Apr 12, 2018

ToolsTest.j will fail as this new version of Flatten must use Node or JavaScriptCore to work. But if we use Node or JavaScriptCore the test case will also fail as Press can not yet run on Node or JavaScriptCore.

So we are waiting for Press to be able to run on Node or JavaScriptCore. As of now I have not had the time to look at this. If someone want to take a look feel free to do so. The solution for Press is similar to this fix for Flatten.

@cappbot cappbot modified the milestones: Someday, 1.0 Apr 12, 2018
@cappbot
Copy link

cappbot commented Apr 12, 2018

Milestone: 1.0. Labels: #needs-improvement, #new. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon.

@daboe01
Copy link
Contributor

daboe01 commented Sep 23, 2018

milestone=1.1

@cappbot
Copy link

cappbot commented Sep 23, 2018

Milestone: 1.1. Labels: #needs-improvement, #new. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon.

@cappbot cappbot modified the milestones: 1.0, 1.1 Sep 23, 2018
@daboe01
Copy link
Contributor

daboe01 commented Aug 19, 2019

-#new

@cappbot cappbot removed the #new label Aug 19, 2019
@cappbot
Copy link

cappbot commented Aug 19, 2019

Milestone: 1.1. Label: #needs-improvement. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon.

@mrcarlberg mrcarlberg mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants