-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Flatten now works with Node.js and JavaScriptCore #2577
base: narwhal
Are you sure you want to change the base?
Conversation
This is excellent work done by @FrankReh with some small bug fixes by me.
Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue. |
milestone=1.0 |
ToolsTest.j will fail as this new version of Flatten must use Node or JavaScriptCore to work. But if we use Node or JavaScriptCore the test case will also fail as Press can not yet run on Node or JavaScriptCore. So we are waiting for Press to be able to run on Node or JavaScriptCore. As of now I have not had the time to look at this. If someone want to take a look feel free to do so. The solution for Press is similar to this fix for Flatten. |
Milestone: 1.0. Labels: #needs-improvement, #new. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon. |
milestone=1.1 |
Milestone: 1.1. Labels: #needs-improvement, #new. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon. |
-#new |
Milestone: 1.1. Label: #needs-improvement. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon. |
This is excellent work done by @FrankReh with some small bug fixes by me.
The ToolsTest.j test case will not work now as it has to be run with Node.js