Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenfield selection and editing is broken #2795

Open
daboe01 opened this issue Mar 10, 2019 · 10 comments · May be fixed by #2894
Open

Tokenfield selection and editing is broken #2795

daboe01 opened this issue Mar 10, 2019 · 10 comments · May be fixed by #2894
Labels
AppKit regression
Milestone
Someday

Comments

@daboe01
Copy link
Contributor

daboe01 commented Mar 10, 2019

you can see this in the manual test. deleting highlighted tokens via backspace leaves the page in firefox, fails to delete token in chrome. you cannot place the caret between tokens via mouse (firefox+chrome) + arrow keys do not work in firefox.
@daboe01
Copy link
Contributor Author

daboe01 commented Mar 10, 2019

i am looking into redoing tokenfield on the basis of CPTextView

@cappbot cappbot added this to the Someday milestone Mar 10, 2019
@cappbot cappbot added the #new label Mar 10, 2019
@cappbot
Copy link

cappbot commented Mar 10, 2019

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@daboe01
Copy link
Contributor Author

daboe01 commented Mar 15, 2019

reimplementation on top of CPTextView is feasible but will take some time.
our best option to get this fixed asap is a git bisect.
@timhowell01 do you know a cappuccino version (commit sha) without the issue?

@timhowell01
Copy link

timhowell01 commented Mar 17, 2019 via email

@timhowell01
Copy link

@daboe01 Just finished with git bisect. The first bad commit is 26aab29

@daboe01
Copy link
Contributor Author

daboe01 commented Mar 17, 2019

@timhowell01 thank you! that makes perfect sense, with respect to the behavior of backspace, that only works when the text field has focus.
@aljungberg could you possibly have a look?

@daboe01
Copy link
Contributor Author

daboe01 commented Mar 28, 2019

+#regression
+AppKit
-#new

@cappbot
Copy link

cappbot commented Mar 28, 2019

Milestone: Someday. Label: AppKit. What's next? A reviewer should examine this issue.

@cappbot cappbot added AppKit and removed #new labels Mar 28, 2019
@daboe01
Copy link
Contributor Author

daboe01 commented Mar 30, 2019

+regression

@cappbot
Copy link

cappbot commented Mar 30, 2019

Milestone: Someday. Labels: AppKit, regression. What's next? A reviewer should examine this issue.

@daboe01 daboe01 mentioned this issue Mar 31, 2019
Open
@daboe01 daboe01 linked a pull request Mar 22, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AppKit regression
Projects
None yet
Milestone
Someday
Development

Successfully merging a pull request may close this issue.

fixed: selection and backspace are recently broken in CPTokenField daboe01/cappuccino
3 participants
@daboe01 @cappbot @timhowell01