Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/core/stories refresh #13854

Merged
merged 9 commits into from May 23, 2024
Merged

/core/stories refresh #13854

merged 9 commits into from May 23, 2024

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented May 8, 2024

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-10478

@webteam-app
Copy link

@juanruitina
Copy link
Contributor

juanruitina commented May 9, 2024

I applied myself the changes agreed with Lyubo, there was a little misunderstanding on our side, feel free to tweak as needed. I also unhid the logos on mobile (no good reason why we should hide them, particularly given how compact they are), and changed a bit the responsiveness to align with https://ubuntu.com/download/alternative-downloads. This seems to be a pattern that might be worth standardising, given that we are using it in other places.

Some things that still need tweaking:

  • HRs and navigation show on top of the side navigation on mobile, maybe a z-index issue?
  • In my screen resolution (1280px), Robotics doesn't get highlighted on the side navigation, neither by scrolling nor by clicking.
  • Similarly, the "Industrial IoT" item never gets highlighted again after going past it the first time.

Copy link
Contributor

@lyubomir-popov lyubomir-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion in the code

templates/core/stories.html Outdated Show resolved Hide resolved
@lyubomir-popov
Copy link
Contributor

Can we please retain the layout of success stories on medium screens like so:
image

requirements.txt Outdated Show resolved Hide resolved
@mtruj013 mtruj013 merged commit 1593ce9 into canonical:main May 23, 2024
13 checks passed
@mtruj013 mtruj013 deleted the core-sucess branch May 23, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants