Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show plus sign when maximum tracking is reached #13810

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Apr 26, 2024

Done

  • Blocked by missing attribute from ua-contracts API
  • Hardcoded maxTracking value for now to show "+" in front of active machines number

QA

  • Check out this feature branch
  • Go to /pro/dashboard
  • See "+" in front of active machines number

Issue / Card

Fixes WD-10492

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.52%. Comparing base (9cd1650) to head (b86f25c).
Report is 87 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13810   +/-   ##
=======================================
  Coverage   74.51%   74.52%           
=======================================
  Files         107      107           
  Lines        2857     2858    +1     
  Branches      957      958    +1     
=======================================
+ Hits         2129     2130    +1     
  Misses        704      704           
  Partials       24       24           
Files Coverage Δ
...scriptionDetails/DetailsContent/DetailsContent.tsx 92.85% <100.00%> (+0.17%) ⬆️
static/js/src/advantage/tests/factories/api.ts 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants