Block channel user from accessing regular pro shop #13799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
minkyngkm
force-pushed
the
wp-10782-block-channel-user-pro-shop
branch
2 times, most recently
from
ab1e546
to
c3e1b8a
Compare
minkyngkm
commented
Apr 25, 2024
Comment on lines
+79
to
+80
| return flask.render_template( | ||
| "account/forbidden.html", reason="channel_account" |
There was a problem hiding this comment.
I thought displaying a forbidden page with a link to the distributor page was better than redirecting to the distributor page immediately but please let me know if the other way is better!
minkyngkm
force-pushed
the
wp-10782-block-channel-user-pro-shop
branch
from
c3e1b8a
to
c84e395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Login with channel account
Go to
/pro/subscribe,/account/checkout,/pro/dashboardCheck forbidden page shows
Login with normal account
Check
/pro/subscribepage accessibleIssue / Card
Fixes #https://warthogs.atlassian.net/browse/WD-10782