Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide error message when value changes #13640

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Mar 4, 2024

Done

QA

  • Go to /pro/subscribe

  • Click "Buy now" button

  • Type invalid VAT number and check global error message displays properly

  • Update VAT field with new number, error message should disappear when the field is updated

  • Type invalid card number and check global error message displays properly

  • Update card number with valid number, save and check that the global error message disappears

  • QA with other error cases as well

Issue / Card

Fixes WD-2941

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13640.demos.haus

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.41%. Comparing base (118a569) to head (6e26dd6).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13640      +/-   ##
==========================================
- Coverage   74.46%   74.41%   -0.06%     
==========================================
  Files         107      107              
  Lines        2847     2849       +2     
  Branches      948      948              
==========================================
  Hits         2120     2120              
- Misses        703      705       +2     
  Partials       24       24              
Files Coverage Δ
.../checkout/components/UserInfoForm/UserInfoForm.tsx 64.56% <0.00%> (-0.52%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants