Documentation layout update #13476
Draft
Documentation layout update #13476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c262b98.
* Remove comment * Update nojs-nav links * Format-python
* Implement GA tracking and a location hash in the URL * Appease the linter gods * Update with code&qa suggestions
Fix keyboarding trapping
* Fix 'quick links' not being tabable on mobile * Add keyboard trapping for mobile * Make query for side-panel more generic * Remove console.logs
* Minor bug fixes * Make global-nav link detection more specific * Fix linter errors
* Fix alignment within grid within bubbles & remove floating black box on mobile * Fix alignment of 'canonical' in the reduced mobile nav * Add missing requirements * Actually add missing requirements * Align navigation to grid text * Appease lint gods * Update color of side nav tabs when active * Align first nav item with text * Appease linter * Align items inside the dropdown ith page text
|
Demo starting at https://ubuntu-com-13476.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13476 +/- ##
==========================================
- Coverage 74.49% 74.35% -0.14%
==========================================
Files 107 107
Lines 2854 2882 +28
Branches 954 982 +28
==========================================
+ Hits 2126 2143 +17
- Misses 704 715 +11
Partials 24 24 |
petesfrench
force-pushed
the
documentation-layout-update
branch
from
9ca625f
to
ae82fd1
Compare
petesfrench
force-pushed
the
meganav-rebase
branch
2 times, most recently
from
d737976
to
187cd7a
Compare
|
@bartaz So this is the current PR updating to the documentation layout. As you can see it is bit of a big one.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
./run serveordotrunIssue / Card
Fixes #
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines