Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /credentials/shop/manage as flask view #13422

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Jan 3, 2024

Done

  • Blocked by Implement /credentials/shop/ as flask view #13464
  • Implementing credentials/shop/manage in Flask view, previously a React App
  • Redesign tab selection to dropdown select
  • Remove the option to rotate/redeem key if key has expired
  • Update tooltip message when key is copied

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Go to credentials/shop/manage
  • The page should function as it did previously with the React implementation

Issue / Card

Fixes WD-7950, WD-9176

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13422.demos.haus

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (0e757cc) to head (0fdaed9).
Report is 138 commits behind head on main.

❗ Current head 0fdaed9 differs from pull request most recent head e311d65. Consider uploading reports for the commit e311d65 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13422      +/-   ##
==========================================
- Coverage   74.49%   74.46%   -0.03%     
==========================================
  Files         107      107              
  Lines        2854     2847       -7     
  Branches      954      948       -6     
==========================================
- Hits         2126     2120       -6     
+ Misses        704      703       -1     
  Partials       24       24              

see 2 files with indirect coverage changes

@britneywwc britneywwc changed the title WIP: Implement flask view for credentials shop Implement flask view for credentials shop Jan 4, 2024
@britneywwc britneywwc force-pushed the flask-credentials-shop branch 6 times, most recently from 2239163 to 59fe5b7 Compare January 10, 2024 05:43
@britneywwc britneywwc changed the title Implement flask view for credentials shop Implement /credentials/shop/manage as flask view Jan 10, 2024
@britneywwc britneywwc force-pushed the flask-credentials-shop branch 3 times, most recently from f755d81 to 57fd3d6 Compare January 19, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants