Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new LoadBalancer svc instead of modifying the Juju ClusterIP svc #356

Merged
merged 16 commits into from
May 29, 2024
Merged

Create new LoadBalancer svc instead of modifying the Juju ClusterIP svc #356

merged 16 commits into from
May 29, 2024

Conversation

IbraAoad
Copy link
Contributor

@IbraAoad IbraAoad commented May 10, 2024 •
edited

Fixes: #319

In tandem with canonical/observability-libs#90

@IbraAoad IbraAoad mentioned this pull request May 10, 2024
Merged
@IbraAoad IbraAoad marked this pull request as ready for review May 22, 2024 12:18
sed-i
sed-i reviewed May 23, 2024
View reviewed changes
actions.yaml Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
tests/integration/helpers.py Show resolved Hide resolved
sed-i
sed-i reviewed May 23, 2024
View reviewed changes
lib/charms/observability_libs/v1/kubernetes_service_patch.py Outdated Show resolved Hide resolved
lib/charms/observability_libs/v1/kubernetes_service_patch.py Outdated Show resolved Hide resolved
lib/charms/observability_libs/v1/kubernetes_service_patch.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
sed-i
sed-i reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@sed-i sed-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few last bits.

lib/charms/observability_libs/v1/kubernetes_service_patch.py Show resolved Hide resolved
lib/charms/observability_libs/v1/kubernetes_service_patch.py Outdated Show resolved Hide resolved
lib/charms/observability_libs/v1/kubernetes_service_patch.py Outdated Show resolved Hide resolved
lib/charms/observability_libs/v1/kubernetes_service_patch.py Show resolved Hide resolved
@IbraAoad IbraAoad merged commit e205641 into main May 29, 2024
13 checks passed
@IbraAoad IbraAoad deleted the OPENG-2274 branch May 29, 2024 10:27
@IbraAoad IbraAoad mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sed-i sed-i sed-i left review comments

@lucabello lucabello lucabello approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada Abuelodelanada is a code owner

@dstathis dstathis Awaiting requested review from dstathis dstathis is a code owner

@mmkay mmkay Awaiting requested review from mmkay mmkay is a code owner

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti PietroPasotti is a code owner

@simskij simskij Awaiting requested review from simskij simskij is a code owner

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new LoadBalancer svc instead of modifying the Juju ClusterIP svc
4 participants
@IbraAoad @simskij @lucabello @sed-i