feat: Adding the Terraform module #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatici
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
PietroPasotti,
sed-i and
simskij
as code owners
gatici
changed the title
gatici
force-pushed
the
TELCO-952-Add-terraform-module
branch
from
581aefc
to
8522eac
Compare
Signed-off-by: gatici <gulsum.atici@canonical.com>
gatici
force-pushed
the
TELCO-952-Add-terraform-module
branch
3 times, most recently
from
85bf33d
to
4dad43b
Compare
gatici
force-pushed
the
TELCO-952-Add-terraform-module
branch
from
4dad43b
to
4c4a70a
Compare
Signed-off-by: gatici <gulsum.atici@canonical.com>
gatici
force-pushed
the
TELCO-952-Add-terraform-module
branch
from
4c4a70a
to
2234395
Compare
|
So, we had a brief discussion about this yesterday, and we haven't really agreed on whether we want the modules scattered across the repos, or if we want all of them in the cos-lite-bundle repo. Let's park this PR until we've had a chance to decide. |
Hello @simskij We will store the traefik-k8s TF module under this repository temporarily https://github.com/canonical/terraform-juju-sdcore-k8s/pull/4/files. When you had a decision, we can move to it's permanent place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR adds the Terraform module for the charm. Hence, the charm could be deployed using the Terraform.