fixed some issues when removing an ingress relation #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
sed-i and
simskij
as code owners
sed-i
reviewed
Feb 7, 2024
| @@ -890,7 +900,15 @@ def _wipe_ingress_for_relation(self, relation: Relation, *, wipe_rel_data=True): | |||
| # Skip this for traefik-route because it doesn't have a `wipe_ingress_data` method. | |||
| provider = self._provider_from_relation(relation) | |||
| if wipe_rel_data and self.unit.is_leader() and provider != self.traefik_route: | |||
| provider.wipe_ingress_data(relation) # type: ignore # this is an ingress-type relation | |||
| try: | |||
| provider.wipe_ingress_data(relation) # type: ignore # this is an ingress-type relation | |||
There was a problem hiding this comment.
Would it work if we do nothing for relation broken?
Juju takes care of the databag - we probably shouldn't worry about cleanup.
Seems wrong to log an ERROR with a reservation.
There was a problem hiding this comment.
mmm, true, not sure what's the goal semantically of wiping the databags. historically traefik's been doing it forever, it's just habit now.
@simskij perhaps has some context?
There was a problem hiding this comment.
perhaps it's a way for the charm to mark for itself that the relation is going away and should not be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When removing a relation between traefik and, say, alertmanager, traefik goes into error state because it fails to wipe the relation databags due to some permission error.
Solution: be more careful with databag cleanup.