Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subdomain certs #274

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Subdomain certs #274

wants to merge 3 commits into from

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Oct 19, 2023 •
edited

Issue

The TLS cert solution was designed with only path routing in mind.
With subdomain routing, traefik is unable to match a domain to a cert.

Solution

  • Refactor to have a cert per app (IPA) or per unit (IPU).
    • when ingress relation (unit) joins/departs, send CSR/CRR on behalf of the unit
    • when routing mode changes from subdomain to path, CRR everything
    • when routing mode changes from path to subdomain, CSR everything
  • Keep using cert_handler as-is for the bare hostname cert. Should keep it even for subdomain routing, to be able to reach traefik api endpoints and metrics endpoint.

Fixes #244.

Context

Testing Instructions

Release Notes

ghislainbourgeois
ghislainbourgeois approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, but I agree with the decision and chosen approach.

doc/adr/2023-10-18 subdomain routing with cert per unit.md Show resolved Hide resolved
doc/adr/2023-10-18 subdomain routing with cert per unit.md Show resolved Hide resolved
doc/adr/2023-10-18 subdomain routing with cert per unit.md Show resolved Hide resolved
gregory-schiano
gregory-schiano approved these changes Oct 23, 2023
View reviewed changes
Copy link

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sed-i sed-i mentioned this pull request Oct 24, 2023
Open
sed-i
sed-i commented Nov 22, 2023
View reviewed changes
src/charm.py Outdated
if self._routing_mode is _RoutingMode.path:
return self.external_host
else: # _RoutingMode.subdomain
prefix = "somehow, from reldata"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PietroPasotti would you be able to help out obtaining the prefix using the new schema classes?
I imagine #269 may have an impact on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simskij simskij simskij left review comments

@ghislainbourgeois ghislainbourgeois ghislainbourgeois approved these changes

@gregory-schiano gregory-schiano gregory-schiano approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada Abuelodelanada will be requested when the pull request is marked ready for review Abuelodelanada is a code owner

@dstathis dstathis Awaiting requested review from dstathis dstathis will be requested when the pull request is marked ready for review dstathis is a code owner

@IbraAoad IbraAoad Awaiting requested review from IbraAoad IbraAoad will be requested when the pull request is marked ready for review IbraAoad is a code owner

@lucabello lucabello Awaiting requested review from lucabello lucabello will be requested when the pull request is marked ready for review lucabello is a code owner

@mmkay mmkay Awaiting requested review from mmkay mmkay will be requested when the pull request is marked ready for review mmkay is a code owner

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti PietroPasotti will be requested when the pull request is marked ready for review PietroPasotti is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subdomain routing mode does not work properly with TLS certificates
4 participants
@sed-i @simskij @ghislainbourgeois @gregory-schiano