Copy signing keys from main to workers #349
Open
+318
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandahla
changed the title
arturo-seijas
previously approved these changes
May 20, 2024
| @@ -58,15 +61,32 @@ def _change_config(self, charm_state: CharmState) -> None: | |||
| Args: | |||
| charm_state: Instance of CharmState | |||
| """ | |||
| if self._charm.get_main_unit() is None and self._charm.unit.is_leader(): | |||
There was a problem hiding this comment.
As far as I see, the method database_observer._change_config is nearly equal to the method charm.change_config. Why not calling the charm method instead? (maybe add that method to the base class of the charm, so no casting is needed)
There was a problem hiding this comment.
I believe this will be better handled/discussed in ISD-1820. What do you think?
There was a problem hiding this comment.
But...this is related to the last commit that I pushed regarding is_main check. I'll wait for the integration tests to run and see the behavior but I think it would be easy to do your suggestion in all observers and just call the charm.change_config method.
There was a problem hiding this comment.
Proposal: Merge this one (after reviews) and then work on the reconcile/restarts in the ISD-1820.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: update charm libraries * remove stored state from redis observer * remove stored state * fix tests * src-docs * fix unit tests * Update test_charm_scaling.py * fix unit tests * fix tests --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Arturo Seijas <arturo.seijas@canonical.com> Co-authored-by: javierdelapuente <javier.delapuente@canonical.com> Co-authored-by: arturo-seijas <102022572+arturo-seijas@users.noreply.github.com>
|
Test coverage for 9bf0b75 Static code analysis report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attention
To be merged after IRC PRs.
Overview
Copy signing keys from main unit to worker since is required to be the same for prevent problems while sending signed events.
Also, check if Redis configuration has changed before restarting Synapse. Redis charm sends the same custom event for relation created and joined.
Rationale
Every unit will sign events with the same key.
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docsurgent,trivial,complex)No doc is changed in CH.