New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add COS agent interface #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Have we tested this with the integration to grafana agent and metrics show up correctly in Prometheus?
It's going to be hard to test this until the UPF/bessd is operational |
Just to be clear, this is referring to this bug right? |
Actually it was this one, where it tries to set affinity on every process, resulting in the script not running if it failed for even 1. This is patched upstream now, as well as the patch is in our snap, so it should be good to go. The second patch is only if you need to re-run the script, like after a bessd restart. |
5b32966
to
b88f8db
Compare
e16574a
to
9561ab2
Compare
9561ab2
to
bfe4e50
Compare
Description
This PR aims to add the
cos-agent
interface as a provider:charmcraft.yaml
with new provider relationNote:
cos-agent
interface requires Pydantic<2, so the charm config validator has been backported to work with pydantic 1.Checklist: