Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add COS agent interface #21

Merged
merged 4 commits into from Mar 30, 2024
Merged

Conversation

dariofaccin
Copy link
Contributor

Description

This PR aims to add the cos-agent interface as a provider:

  • Update charmcraft.yaml with new provider relation
  • Update requirements
  • Add integration test

Note: cos-agent interface requires Pydantic<2, so the charm config validator has been backported to work with pydantic 1.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@dariofaccin dariofaccin requested a review from a team as a code owner March 19, 2024 15:28
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Have we tested this with the integration to grafana agent and metrics show up correctly in Prometheus?

tests/integration/test_charm.py Outdated Show resolved Hide resolved
@markbeierl
Copy link
Contributor

It's going to be hard to test this until the UPF/bessd is operational

@gruyaume
Copy link
Collaborator

It's going to be hard to test this until the UPF/bessd is operational

Just to be clear, this is referring to this bug right?

@markbeierl
Copy link
Contributor

markbeierl commented Mar 20, 2024

Actually it was this one, where it tries to set affinity on every process, resulting in the script not running if it failed for even 1.

This is patched upstream now, as well as the patch is in our snap, so it should be good to go.

The second patch is only if you need to re-run the script, like after a bessd restart.

@dariofaccin dariofaccin force-pushed the TELCO-1006-add_cos_interface branch 3 times, most recently from e16574a to 9561ab2 Compare March 29, 2024 09:41
@dariofaccin dariofaccin merged commit 9bd1e62 into main Mar 30, 2024
14 checks passed
@dariofaccin dariofaccin deleted the TELCO-1006-add_cos_interface branch March 30, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants